tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] trevor-m commented on a change in pull request #5320: [BYOC] Prevent duplicate outputs in subgraph Tuple
Date Mon, 13 Apr 2020 20:22:30 GMT
trevor-m commented on a change in pull request #5320: [BYOC] Prevent duplicate outputs in subgraph
Tuple
URL: https://github.com/apache/incubator-tvm/pull/5320#discussion_r407693736
 
 

 ##########
 File path: tests/python/relay/test_annotated_regions.py
 ##########
 @@ -56,7 +56,7 @@ def test_region_set_creator_diamond():
         'test_target',
         [cb_1],
         [cb_1, O_1, ce_1, ce_2],
-        [ce_1, ce_2],
 
 Review comment:
   @mbaret @comaniac `ce_1` and `ce_2` are duplicates here. I had to make this change to this
test to get it to pass after my fix. Is it important that AnnotatedRegions could have duplicate
outputs? Is there a use case for annotatedRegions outside of the MergeCompilerRegions/PartitionGraph
flow?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message