tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] zhiics commented on a change in pull request #5310: [BYOC] Enhance partitioning and external codegen
Date Sun, 12 Apr 2020 01:24:54 GMT
zhiics commented on a change in pull request #5310: [BYOC] Enhance partitioning and external
codegen
URL: https://github.com/apache/incubator-tvm/pull/5310#discussion_r407131055
 
 

 ##########
 File path: src/relay/transforms/partition_graph.cc
 ##########
 @@ -148,25 +148,42 @@ class Partitioner : public ExprMutator {
       CHECK_EQ(call->args.size(), 1U);
 
       // Traverse the rest graph.
-      auto input_expr = VisitExpr(call->args[0]);
+      Expr parent = call->args[0];
+      auto input_expr = VisitExpr(parent);
+
+      // Backtrace the parent to find the LCA node that is not a begin/ end op
 
 Review comment:
   yeah, it should be LCA, like A-->end1->begin->B
                                                    -->end2->begin->C
   
   If B and C are in the same region, A should have only one out this region instead of two.
A is the LCA of B and C.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message