tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] masahi commented on a change in pull request #5272: [BYOC] Add example of Composite + Annotate for DNNL fused op
Date Fri, 10 Apr 2020 22:52:34 GMT
masahi commented on a change in pull request #5272: [BYOC] Add example of Composite + Annotate
for DNNL fused op
URL: https://github.com/apache/incubator-tvm/pull/5272#discussion_r406974254
 
 

 ##########
 File path: src/relay/backend/contrib/dnnl/codegen.cc
 ##########
 @@ -53,163 +141,186 @@ class CodegenDNNL : public ExprVisitor, public CodegenCBase {
   }
 
   void VisitExpr_(const TupleGetItemNode* op) final {
-    // Do nothing
+    VisitExpr(op->tuple);
 
 Review comment:
   I wondered why this change is on my diff, but it seems TupleGetItemNode handling was reverted
in #5277 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message