tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] zhiics commented on a change in pull request #5276: [REFACTOR][IR] Move to runtime::String
Date Wed, 08 Apr 2020 23:53:19 GMT
zhiics commented on a change in pull request #5276: [REFACTOR][IR] Move to runtime::String
URL: https://github.com/apache/incubator-tvm/pull/5276#discussion_r405879639
 
 

 ##########
 File path: src/node/serialization.cc
 ##########
 @@ -102,7 +102,7 @@ class NodeIndexer : public AttrVisitor {
       for (const auto& kv : n->data) {
         MakeIndex(const_cast<Object*>(kv.second.get()));
       }
-    } else {
+    } else if (!node->IsInstance<StringObj>()) {
 
 Review comment:
   @tqchen Could you please please take a look at the serialization of String here? I am not
sure why the size of the String I loaded back is always 0.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message