tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] tqchen commented on a change in pull request #5276: [REFACTOR][IR] Move to runtime::String
Date Wed, 08 Apr 2020 22:29:22 GMT
tqchen commented on a change in pull request #5276: [REFACTOR][IR] Move to runtime::String
URL: https://github.com/apache/incubator-tvm/pull/5276#discussion_r405851011
 
 

 ##########
 File path: src/relay/backend/graph_runtime_codegen.cc
 ##########
 @@ -419,7 +419,7 @@ class GraphRuntimeCodegen
     auto pf1 = GetPackedFunc("relay.backend._CompileEngineLower");
     Target target;
     // Handle external function
-    if (func->GetAttr<tir::StringImm>(attr::kCompiler).defined()) {
+    if (func->GetAttr<runtime::String>(attr::kCompiler).defined()) {
 
 Review comment:
   Let us consider expose runtime::String to the tvm namespace as well(by put using runtime::String
in the tvm namespace of container.h) So that we can directly type GetAttr<String>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message