tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] comaniac commented on issue #5277: [BYOC] Refine AnnotateTarget and MergeCompilerRegion Passes
Date Wed, 08 Apr 2020 18:03:48 GMT
comaniac commented on issue #5277: [BYOC] Refine AnnotateTarget and MergeCompilerRegion Passes
URL: https://github.com/apache/incubator-tvm/pull/5277#issuecomment-611106645
 
 
   > By moving AnnotateRestDefault's functionality into AnnotateTarget, won't that prevent
us from being able to run AnnotateTarget multiple times (because it will annotate defaults
multiple times)?
   
   Even the original implementation has the similar issue because it didn't check if an argument
is compiler end. I'm making a commit to only modify the annotation attribute for the current
target if the annotation has already there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message