tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] jwfromm commented on a change in pull request #5186: [Relay][Topi][AutoTVM] Winograd support for Conv3D
Date Sat, 04 Apr 2020 22:14:51 GMT
jwfromm commented on a change in pull request #5186: [Relay][Topi][AutoTVM] Winograd support
for Conv3D
URL: https://github.com/apache/incubator-tvm/pull/5186#discussion_r403539789
 
 

 ##########
 File path: src/relay/op/nn/convolution.h
 ##########
 @@ -360,6 +363,540 @@ bool Conv3DRel(const Array<Type>& types, int num_inputs,
const Attrs& attrs,
   return true;
 }
 
+
+// Winograd convolution shape relations
+template<typename AttrType>
 
 Review comment:
   Thanks @masahi, making them inline functions is a better design. My latest commit changes
all relevant templates into inline functions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message