tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] mbrookhart commented on a change in pull request #4886: [RELAY] Non-recursive Graph Vistor and Rewriter
Date Fri, 03 Apr 2020 15:49:34 GMT
mbrookhart commented on a change in pull request #4886: [RELAY] Non-recursive Graph Vistor
and Rewriter
URL: https://github.com/apache/incubator-tvm/pull/4886#discussion_r403100509
 
 

 ##########
 File path: src/relay/ir/expr_functor.cc
 ##########
 @@ -211,12 +365,12 @@ Expr ExprMutator::VisitExpr_(const MatchNode* m) {
   for (const Clause& p : m->clauses) {
     clauses.push_back(VisitClause(p));
   }
-  return Match(VisitExpr(m->data), clauses, m->complete);
 
 Review comment:
   @tqchen Every other method in this class already uses mutate instead of VisitExpr, this
makes ExprMutator more internally consistent, even if it's not strictly needed. I prefer it
for that reason, but it doesn't need to be part of the PR, if you really want me to remove
it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message