tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] jjohnson-arm commented on issue #5204: [Frontend][Torch] Fix up graph input handling
Date Thu, 02 Apr 2020 11:05:54 GMT
jjohnson-arm commented on issue #5204: [Frontend][Torch] Fix up graph input handling
URL: https://github.com/apache/incubator-tvm/pull/5204#issuecomment-607778261
 
 
   > @jjohnson-arm Unfortunately, you've just hit a known flaky test failure. Please comment
out the get_valid_count test. See [#4901 (comment)](https://github.com/apache/incubator-tvm/pull/4901#issuecomment-595040094)
   > 
   > Also have you verified that torch frontend tests work with this PR? I'm not sure some
of the usage of `update()` method is supported.
   
   Will comment out the test.
   I have been runnning the `tests/python/frontend/pytorch/test_forward.py` tests for all
my changes, and it works fine (using Python 3.6.10). Seems that python from 3.5 has supported
tuples etc - https://docs.python.org/3.5/library/stdtypes.html?highlight=update#dict.update,
so should be okay?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message