tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] mbaret commented on a change in pull request #5195: [RELAY] Fixes to MergeCompilerRegions
Date Wed, 01 Apr 2020 14:51:41 GMT
mbaret commented on a change in pull request #5195: [RELAY] Fixes to MergeCompilerRegions
URL: https://github.com/apache/incubator-tvm/pull/5195#discussion_r401676709
 
 

 ##########
 File path: src/relay/transforms/annotate_target.cc
 ##########
 @@ -52,6 +55,13 @@ class AnnotateTargetWrapper : public ExprMutator {
         return fannotate[op](call->attrs, call->args);
       }
     }
+    if (expr->IsInstance<TupleGetItemNode>()) {
 
 Review comment:
   I'm not sure yet what we plan on doing with Let nodes (or Ref* nodes). I think just saying
they're not supported is sufficient for now though without also throwing an error.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message