From commits-return-9674-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Fri Mar 27 18:03:42 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B9237180637 for ; Fri, 27 Mar 2020 19:03:41 +0100 (CET) Received: (qmail 54618 invoked by uid 500); 27 Mar 2020 18:03:41 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 54609 invoked by uid 99); 27 Mar 2020 18:03:41 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Mar 2020 18:03:41 +0000 From: GitBox To: commits@tvm.apache.org Subject: [GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. Message-ID: <158533222103.12347.563334324717066860.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Fri, 27 Mar 2020 18:03:41 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit MarisaKirisame commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399448385 ########## File path: tests/python/unittest/test_tir_structural_equal.py ########## @@ -55,8 +55,8 @@ def test_exprs(): assert tvm.ir.structural_equal(zx * zx, zx * zx) assert tvm.ir.structural_equal(zx * zx, zy * zy, map_free_vars=True) assert not tvm.ir.structural_equal(zx * zx, zy * zy, map_free_vars=False) - assert not tvm.ir.structural_equal(zx * zx, (vx + vx) * (vx + vx), - map_free_vars=False) + assert tvm.ir.structural_equal(zx * zx, (vx + vx) * (vx + vx), Review comment: I see, make sense to me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services