From commits-return-9598-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Thu Mar 26 20:01:19 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id ACDC6180637 for ; Thu, 26 Mar 2020 21:01:18 +0100 (CET) Received: (qmail 69442 invoked by uid 500); 26 Mar 2020 20:01:18 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 69428 invoked by uid 99); 26 Mar 2020 20:01:18 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Mar 2020 20:01:18 +0000 From: GitBox To: commits@tvm.apache.org Subject: [GitHub] [incubator-tvm] zhiics commented on a change in pull request #5153: Adding support for QNN subtract op Message-ID: <158525287800.3934.7495348893717466069.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Thu, 26 Mar 2020 20:01:18 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit zhiics commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r398855417 ########## File path: src/relay/qnn/op/op_common.h ########## @@ -30,14 +30,151 @@ #include #include #include "../../op/type_relations.h" +#include "../../transforms/infer_layout_util.h" +#include "../util.h" namespace tvm { namespace relay { namespace qnn { -static inline bool QnnBroadcastRel(const Array& types, int num_inputs, const Attrs& attrs, +/* + * Number of inputs for the Qnn binary operators. + * Refer the QNN_REGISTER_BINARY_OP macro to see + * what the operators are. + */ +static constexpr int numQnnBinaryOpInputs = 8; Review comment: usually we use `kNumQnnBinaryOpInputs` for consts ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services