From commits-return-8090-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Sat Mar 7 12:53:59 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 02F9218025F for ; Sat, 7 Mar 2020 13:53:58 +0100 (CET) Received: (qmail 82043 invoked by uid 500); 7 Mar 2020 12:53:58 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 82032 invoked by uid 99); 7 Mar 2020 12:53:58 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Mar 2020 12:53:58 +0000 From: GitBox To: commits@tvm.apache.org Subject: [GitHub] [incubator-tvm] liangfu commented on a change in pull request #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support Message-ID: <158358563824.19942.11257554669501189095.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sat, 07 Mar 2020 12:53:58 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit liangfu commented on a change in pull request #4986: [VTA][Chisel,de10nano] Chisel fixes and de10nano support URL: https://github.com/apache/incubator-tvm/pull/4986#discussion_r389245910 ########## File path: vta/hardware/intel/scripts/soc_system.tcl ########## @@ -33,7 +33,156 @@ set_instance_parameter_value clk_0 {clockFrequencyKnown} {1} set_instance_parameter_value clk_0 {resetSynchronousEdges} {NONE} add_instance hps_0 altera_hps 18.1 +set_instance_parameter_value hps_0 {ABSTRACT_REAL_COMPARE_TEST} {0} Review comment: Can we reduce the generated code to a minimal number while preserve this is all functional? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services