From commits-return-7873-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Thu Mar 5 20:55:04 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 69556180667 for ; Thu, 5 Mar 2020 21:55:04 +0100 (CET) Received: (qmail 57518 invoked by uid 500); 5 Mar 2020 20:55:03 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 57509 invoked by uid 99); 5 Mar 2020 20:55:03 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Mar 2020 20:55:03 +0000 From: GitBox To: commits@tvm.apache.org Subject: [GitHub] [incubator-tvm] alexwong commented on a change in pull request #4964: [Torch] Add initial control flow support Message-ID: <158344170362.30090.7211684905531833664.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Thu, 05 Mar 2020 20:55:03 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit alexwong commented on a change in pull request #4964: [Torch] Add initial control flow support URL: https://github.com/apache/incubator-tvm/pull/4964#discussion_r388557544 ########## File path: python/tvm/relay/frontend/pytorch.py ########## @@ -842,7 +898,13 @@ def _convert_elemwise_input(data, input_type): "aten::detach" : _identity(), "aten::upsample_bilinear2d" : _upsample("bilinear"), "aten::upsample_nearest2d" : _upsample("nearest_neighbor"), - "aten::expand_as" : _expand_as() + "aten::expand_as" : _expand_as(), + 'aten::lt' : _lt(), Review comment: Nitpick: Can we add aten::le, aten::ge, aten::ne ops? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services