tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] tqchen commented on a change in pull request #5161: [Refactor][ir] alpha_equal to structural_equal
Date Sat, 28 Mar 2020 18:50:49 GMT
tqchen commented on a change in pull request #5161: [Refactor][ir] alpha_equal to structural_equal
URL: https://github.com/apache/incubator-tvm/pull/5161#discussion_r399695608
 
 

 ##########
 File path: include/tvm/ir/type_relation.h
 ##########
 @@ -203,7 +203,6 @@ class TypeRelationNode : public TypeConstraintNode {
 
   bool SEqualReduce(const TypeRelationNode* other, SEqualReducer equal) const {
     return
-        equal(func, other->func) &&
 
 Review comment:
   Let us keep this comparison. we can fix the EnvFunc's SEqual instead by comparing the name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message