tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.
Date Fri, 27 Mar 2020 17:40:28 GMT
tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra
for the unified IR.
URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399434631
 
 

 ##########
 File path: tests/python/unittest/test_tir_structural_equal.py
 ##########
 @@ -55,8 +55,8 @@ def test_exprs():
     assert tvm.ir.structural_equal(zx * zx, zx * zx)
     assert tvm.ir.structural_equal(zx * zx, zy * zy, map_free_vars=True)
     assert not tvm.ir.structural_equal(zx * zx, zy * zy, map_free_vars=False)
-    assert not tvm.ir.structural_equal(zx * zx, (vx + vx) * (vx + vx),
-                                       map_free_vars=False)
+    assert tvm.ir.structural_equal(zx * zx, (vx + vx) * (vx + vx),
 
 Review comment:
   Note that the main point of difference is whether we treat a node as graph node or normal
one. the current semantics on the TIR is to treat expr nodes as normal nodes. We could change
the definition by marking all TIR expr as graph nodes as well, which will give the other behavior.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message