tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] zhiics commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.
Date Fri, 27 Mar 2020 17:13:10 GMT
zhiics commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra
for the unified IR.
URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399416785
 
 

 ##########
 File path: include/tvm/relay/expr.h
 ##########
 @@ -107,7 +107,13 @@ class TupleNode : public ExprNode {
   }
 
   bool SEqualReduce(const TupleNode* other, SEqualReducer equal) const {
-    return equal(fields, other->fields);
+    // specially handle empty tuple as constant and not a graph node.
 
 Review comment:
   a/and/is ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message