tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] trevor-m commented on issue #4847: Return empty CSourceModule when no lowered_funcs exists in Relay mod
Date Tue, 24 Mar 2020 16:59:09 GMT
trevor-m commented on issue #4847: Return empty CSourceModule when no lowered_funcs exists
in Relay mod
URL: https://github.com/apache/incubator-tvm/pull/4847#issuecomment-603369453
 
 
   > I think changing it to a llvm module and import all submodules is okay. Now if you
only have an external module. You will need to create a llvm module first and them import
the external module to it.
   > 
   > Stepping into llvm module to find the symbol is not wrong because we will always try
to find the symbol from the host module first. If it is not found, we will then try to check
each imported module. See the code here:
   > 
   > https://github.com/apache/incubator-tvm/blob/050f2bde2c694af9b5569ca954ca041c3767787b/src/runtime/module.cc#L65
   > 
   > A minimal example to reproduce this and track the root cause would be more helpful.
   
   You can reproduce this by running `test_extern_dnnl()` after commenting out this line:
https://github.com/apache/incubator-tvm/blob/master/tests/python/relay/test_pass_partition_graph.py#L203

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message