tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] wyc-ruiker commented on a change in pull request #5142: [Torch] Add support for max_pool1d
Date Tue, 24 Mar 2020 12:47:07 GMT
wyc-ruiker commented on a change in pull request #5142: [Torch] Add support for max_pool1d
URL: https://github.com/apache/incubator-tvm/pull/5142#discussion_r397124944
 
 

 ##########
 File path: tests/python/frontend/pytorch/test_forward.py
 ##########
 @@ -363,9 +363,35 @@ class MaxPool2D2(Module):
         def forward(self, *args):
             return torch.nn.MaxPool2d(kernel_size=[10, 10])(args[0])
 
+    class MaxPool2D3(Module):
 
 Review comment:
   > I am talking about the same point as https://github.com/apache/incubator-tvm/pull/5142/files#r397046667
   > 
   > Yes, you should have a test, but no need to write a wrapper class
   
   Thanks. I misunderstood your review suggestion :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message