tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] hypercubestart commented on a change in pull request #5039: [Relay] GradientCell Relay Pass
Date Mon, 23 Mar 2020 01:15:25 GMT
hypercubestart commented on a change in pull request #5039: [Relay] GradientCell Relay Pass
URL: https://github.com/apache/incubator-tvm/pull/5039#discussion_r396173670
 
 

 ##########
 File path: src/relay/transforms/gradient_cell.cc
 ##########
 @@ -44,19 +66,139 @@
 namespace tvm {
 namespace relay {
 
+namespace GradientCellPass { // avoid polluting namespace
 
 Review comment:
   done thanks for the review!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message