tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] tqchen edited a comment on issue #5077: [Refactor][Relay] Refactor Relay Python to use new FFI
Date Mon, 16 Mar 2020 16:31:12 GMT
tqchen edited a comment on issue #5077: [Refactor][Relay] Refactor Relay Python to use new
FFI
URL: https://github.com/apache/incubator-tvm/pull/5077#issuecomment-599633163
 
 
   Some comments about docs and structure exposure.
   
   - We could consider remove register_relay_node and just call into tvm._ffi.register_object
   - For user facing ypython API, we want to make sure that they are consistent with the namespace
structure. 
     - For example, while a lot of APIs are defined in tvm.tir.expr, we only expose them in
tvm.tir https://docs.tvm.ai/api/python/tir.html
     - This means ideally we want to show tvm.relay.Constant in our docs.
     - Notably, we might encouter aliases, in which case we want to be able to mark them via
https://github.com/apache/incubator-tvm/blob/master/docs/conf.py#L255, see https://docs.tvm.ai/api/python/te.html#tvm.te.abs
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message