tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] wrongtest commented on issue #4459: [RUNTIME] Implement TVMDSOOp(TensorFlow custom op) for TVM runtime
Date Thu, 12 Mar 2020 04:30:00 GMT
wrongtest commented on issue #4459: [RUNTIME] Implement TVMDSOOp(TensorFlow custom op) for
TVM runtime
URL: https://github.com/apache/incubator-tvm/pull/4459#issuecomment-598000668
 
 
   > I think leaving it under the contrib fold is probably not very good because we are
not really testing them. There are some alternatives in my mind.
   > 
   > * We can probably add the tests under "apps". There are some examples that you can
take a look.
   > * Another option would be to detect if this feature is enabled or not. If it is not,
we need to skip the test (but this means we may never test them).
   > 
   > @tqchen thoughts/suggestions for tests?
   
   
   
   > I think leaving it under the contrib fold is probably not very good because we are
not really testing them. There are some alternatives in my mind.
   > 
   > * We can probably add the tests under "apps". There are some examples that you can
take a look.
   > * Another option would be to detect if this feature is enabled or not. If it is not,
we need to skip the test (but this means we may never test them).
   > 
   > @tqchen thoughts/suggestions for tests?
   
   Will things under apps get tested during CI?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message