tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] anwang2009 edited a comment on issue #4960: [Relay][Pass] Add submodule extraction pass
Date Wed, 11 Mar 2020 18:17:49 GMT
anwang2009 edited a comment on issue #4960: [Relay][Pass] Add submodule extraction pass
URL: https://github.com/apache/incubator-tvm/pull/4960#issuecomment-597790227
 
 
   Thanks for everyone's reviews! In line with @zhiics's suggestion I have made this a transform
ModulePass that gathers the fused primitive functions in a result IRModule's functions. We
decided in the RFC to make this an analysis pass; however, the only existing ModulePass examples
I found were registered as transform passes. 
   The "spirit" of the pass is still analysis, but we should register this as a transform
pass for consistency, as it outputs an IRModule.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message