tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] vegaluisjose commented on a change in pull request #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support
Date Fri, 06 Mar 2020 18:24:37 GMT
vegaluisjose commented on a change in pull request #4986: [VTA][Chisel,de10nano] Chisel fixes
and de10nano support
URL: https://github.com/apache/incubator-tvm/pull/4986#discussion_r389067200
 
 

 ##########
 File path: vta/hardware/chisel/src/main/scala/core/TensorStore.scala
 ##########
 @@ -62,20 +62,40 @@ class TensorStore(tensorType: String = "none", debug: Boolean = false)(
   val tag = Reg(UInt(8.W))
   val set = Reg(UInt(8.W))
 
+  // Dynamically adjust the size of DMA transfers to avoid crossing page boundaries.
+  final val ADAPTIVE_DMA_XFER_ENABLE = true
 
 Review comment:
   I see, AFAIK the problem is systematic across all platforms, so we might want to fix it
right away. Also, I believe `de10-nano` is `AXI3`, therefore other platforms using `AXI4`
should also work with this because AXI's _"backwards compatibility."_
   
   Later, we can optimize for performance if we would like to.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message