tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] LiangHao151941 commented on issue #4828: [QNN][TFLite] TFLite rounding mode support
Date Fri, 06 Mar 2020 15:50:39 GMT
LiangHao151941 commented on issue #4828: [QNN][TFLite] TFLite rounding mode support
URL: https://github.com/apache/incubator-tvm/pull/4828#issuecomment-595830052
 
 
   > I don't think we should add tflite_mode attr to Pool2D op. It seems adhoc to me.
   > 
   > I think we can directly implement the UPWARD rounding in pooling, **whenever the datatype
is interger**. For integer division, it is valid to implement rounding by default.
   > 
   > If the tests fail for integer pool, we can change those tests as well. I added those
tests in #3607. Prior to that integer computation in pooling was wrong.
   
   I like the idea, default pooling implementation is updated. Please have a look @anijain2305
@FrozenGene 
   
   I think one more thing is left that one of the qnn full net will trigger gpu test related
segment fault, not quite familiar with gpu part of code, you guys have any ideas on this?
I think we have the problem since tflite rounding mode is introduced. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message