tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] liangfu edited a comment on issue #4998: [VTA][Chisel] Change Scala Linter scalafmt => scalastyle
Date Fri, 06 Mar 2020 05:53:26 GMT
liangfu edited a comment on issue #4998: [VTA][Chisel] Change Scala Linter scalafmt => scalastyle
URL: https://github.com/apache/incubator-tvm/pull/4998#issuecomment-595612183
 
 
   In addition, based on the suggestions in the linter, I made some final changes in fixing
indentation errors, here is a typical example:
   ```diff
   diff --git a/vta/hardware/chisel/src/main/scala/core/Load.scala b/vta/hardware/chisel/src/main/scala/core/Load.scala
   index 7c79498bd..50c26bb8e 100644
   --- a/vta/hardware/chisel/src/main/scala/core/Load.scala
   +++ b/vta/hardware/chisel/src/main/scala/core/Load.scala
   @@ -25,12 +25,12 @@ import vta.util.config._
    import vta.shell._
    
    /** Load.
   -  *
   -  * Load inputs and weights from memory (DRAM) into scratchpads (SRAMs).
   -  * This module instantiate the TensorLoad unit which is in charge of
   -  * loading 1D and 2D tensors to scratchpads, so it can be used by
   -  * other modules such as Compute.
   -  */
   + *
   + * Load inputs and weights from memory (DRAM) into scratchpads (SRAMs).
   + * This module instantiate the TensorLoad unit which is in charge of
   + * loading 1D and 2D tensors to scratchpads, so it can be used by
   + * other modules such as Compute.
   + */
    class Load(debug: Boolean = false)(implicit p: Parameters) extends Module {
      val mp = p(ShellKey).memParams
      val io = IO(new Bundle {
   @@ -110,11 +110,10 @@ class Load(debug: Boolean = false)(implicit p: Parameters) extends
Module {
          when(dec.io.isSync) {
            printf("[Load] start sync\n")
          }.elsewhen(dec.io.isInput) {
   -          printf("[Load] start input\n")
   -        }
   -        .elsewhen(dec.io.isWeight) {
   -          printf("[Load] start weight\n")
   -        }
   +        printf("[Load] start input\n")
   +      }.elsewhen(dec.io.isWeight) {
   +        printf("[Load] start weight\n")
   +      }
        }
        // done
        when(state === sSync) {
   ```
   Please take another look.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message