tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] pasqoc commented on a change in pull request #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support
Date Thu, 05 Mar 2020 21:28:04 GMT
pasqoc commented on a change in pull request #4986: [VTA][Chisel,de10nano] Chisel fixes and
de10nano support
URL: https://github.com/apache/incubator-tvm/pull/4986#discussion_r388575975
 
 

 ##########
 File path: vta/hardware/chisel/Makefile
 ##########
 @@ -109,7 +133,7 @@ else
   lib_path = $(vta_dir)/$(BUILD_NAME)/$(VTA_LIBNAME).so
 endif
 
-default: lint lib
 
 Review comment:
   I really don't mind if lint stays or not.
   Given your preference I am going to put it back.
   But there is definitely a bug in either scalafmt or the way sbt calls it.
   I tried to change the scalafmt configuration to fix the indentation but without success...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message