tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support
Date Thu, 05 Mar 2020 20:06:43 GMT
tmoreau89 commented on a change in pull request #4986: [VTA][Chisel,de10nano] Chisel fixes
and de10nano support
URL: https://github.com/apache/incubator-tvm/pull/4986#discussion_r388533974
 
 

 ##########
 File path: vta/hardware/chisel/Makefile
 ##########
 @@ -109,7 +133,7 @@ else
   lib_path = $(vta_dir)/$(BUILD_NAME)/$(VTA_LIBNAME).so
 endif
 
-default: lint lib
 
 Review comment:
   It is indeed an odd indentation choice, but I would be in favor of enabling lint even if
the output is odd to have uniformity/consistency across the Chisel codebase. @liangfu @vegaluisjose
any input on why the indentation of the `}` looks funky?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message