tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] FrozenGene commented on issue #4990: [Relay][Topi] BatchNorm support with run-time mean and variance calculation
Date Thu, 05 Mar 2020 08:58:45 GMT
FrozenGene commented on issue #4990: [Relay][Topi] BatchNorm support with run-time mean and
variance calculation
URL: https://github.com/apache/incubator-tvm/pull/4990#issuecomment-595107872
 
 
   I think we needn't add `_empty_for_training_mode_inference`. If we find `mean` / `variance`
is `VarNode`, we should call `Mean` and `Variance`.
   
   I don't think we should add `is_training` flag to relay `BatchNorm`. This should be done
by users to make sure TF's model `BatchNorm`'s `is_training` flag be false. However, we still
have user cases like you mention, so we could support as current implementation and don't
add attribute to `BatchNorm`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message