Return-Path: 
 <dev-return-51627-apmail-tuscany-dev-archive=tuscany.apache.org@tuscany.apache.org>
X-Original-To: apmail-tuscany-dev-archive@www.apache.org
Delivered-To: apmail-tuscany-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 169B89AAA
	for <apmail-tuscany-dev-archive@www.apache.org>;
 Thu, 22 Mar 2012 10:49:22 +0000 (UTC)
Received: (qmail 26173 invoked by uid 500); 22 Mar 2012 10:49:21 -0000
Delivered-To: apmail-tuscany-dev-archive@tuscany.apache.org
Received: (qmail 26126 invoked by uid 500); 22 Mar 2012 10:49:21 -0000
Mailing-List: contact dev-help@tuscany.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@tuscany.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@tuscany.apache.org>
List-Post: <mailto:dev@tuscany.apache.org>
List-Id: <dev.tuscany.apache.org>
Reply-To: dev@tuscany.apache.org
Delivered-To: mailing list dev@tuscany.apache.org
Received: (qmail 26116 invoked by uid 99); 22 Mar 2012 10:49:21 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Mar 2012 10:49:21 +0000
X-ASF-Spam-Status: No, hits=-0.7 required=5.0
	tests=RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: domain of ant.elder@gmail.com designates
 209.85.210.53 as permitted sender)
Received: from [209.85.210.53] (HELO mail-pz0-f53.google.com) (209.85.210.53)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Mar 2012 10:49:13 +0000
Received: by dady25 with SMTP id y25so1691440dad.26
        for <dev@tuscany.apache.org>; Thu, 22 Mar 2012 03:48:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        bh=dg8hsQqAVms7NT13dlNicbmUiagywMK5SdKMnEguZyY=;
        b=Cl1L9WvEEynV83MSlPXRIXnT52vdjxRb6MSQbQJtATuKLcquYM+XhtZWizeSkgMAls
         kLQC0l3Z/TCfiqG4z+M7v03w16KfE8gdYhoYQRgq0ejD99EnS0wlhPI+zGJbxGgZWHyt
         EKg6u/+y6YqWXtqGPjrcUTlA7kuJ8iKUBipOpQsrR2IOMgiJORTy22D0yI7bz8ZbJk3U
         pSI6ZW2YugZLIMXDHCyjoAbfca8z4tn9a/hWp3vjSS8A1Q50SRf2LGOyiWrUkp7KN8gC
         7+HwKol9nTGBPT6JwI+SS0XmPHtszEp3W8cPkCcReWyeh2m46zCVGOAyOPqOwrM1l8p/
         e3zg==
MIME-Version: 1.0
Received: by 10.68.223.42 with SMTP id qr10mr19618008pbc.127.1332413332424;
 Thu, 22 Mar 2012 03:48:52 -0700 (PDT)
Received: by 10.68.220.101 with HTTP; Thu, 22 Mar 2012 03:48:52 -0700 (PDT)
In-Reply-To: 
 <CAGU5spfuF=JbXsUD_vMMEn++qOHR5iXrodjY_okScVXPPzHiNA@mail.gmail.com>
References: <20120319080905.5B7AF238897A@eris.apache.org>
	<363167B6-069E-4DE9-8096-35C386D87FA7@gmail.com>
	<5D76831B-301B-469B-8C59-A38E637C989A@gmail.com>
	<CAJO+Ubsw9rMVck5OQkVdKXTP7BSV=wwON1VkAGHyyg5SndX4Xg@mail.gmail.com>
	<CAGU5spfuF=JbXsUD_vMMEn++qOHR5iXrodjY_okScVXPPzHiNA@mail.gmail.com>
Date: Thu, 22 Mar 2012 10:48:52 +0000
Message-ID: 
 <CAJO+UbuZ_5VSyREwvxS5UbED+f7m7-jM2Jx0pLr_A+MNGJriiQ@mail.gmail.com>
Subject: Re: svn commit: r1302317 -
 /tuscany/sca-java-2.x/trunk/modules/core/src/main/java/org/apache/tuscany/sca/core/runtime/impl/EndpointReferenceBinderImpl.java
From: ant elder <ant.elder@gmail.com>
To: dev@tuscany.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-Virus-Checked: Checked by ClamAV on apache.org

On Wed, Mar 21, 2012 at 10:35 PM, Luciano Resende <luckbr1975@gmail.com> wr=
ote:
> On Wed, Mar 21, 2012 at 2:57 PM, ant elder <ant.elder@gmail.com> wrote:
>> On Wed, Mar 21, 2012 at 9:48 PM, Raymond Feng <enjoyjava@gmail.com> wrot=
e:
>>> Hi,
>>>
>>> The change had a huge impact on all the binding invokers that rely on t=
he service binding to resolve the deployed URIs when the endpoint reference=
 is resolved to a target endpoint.
>>>
>>> BTW, the use case applies to something like the following:
>>>
>>> <component name=3D"A">
>>> <service name=3D"S1">
>>> <tuscany:binding.rest uri=3D"/a/b"/>
>>> </service>
>>> </component>
>>>
>>> <component name=3D"B">
>>> <reference name=3D"r1" target=3D"A/S1"/>
>>> </component>
>>>
>>> The r1 reference is now have /a/b as the uri instead of the deployed UR=
I. Ideally, the binding invoker should ask for the target endpoint's deploy=
ed URI. But it involves quite a bit changes.
>>>
>>> I'll revert the change for now until we find a consistent solution.
>>>
>>
>> Raymond, I think you know that unilaterally reverting a commit like
>> that is not the way to do things.
>>
>> =A0 ...ant
>
>
> I don't see this as "unilaterally reverting a commit". I see this as a
> commit extensively broke existing functionality, the issue was brought
> up in the mailing list for discussion of a better fix, while, in the
> mean time, the commit was reverted.
>
> Please let's concentrate on the technical facts and try to find a
> solution that works without huge impact on existing functionality.
>

Luciano, the build didn't get broken until the r1303591 commit so
phrases like "extensively broke" do nothing to constructively help
find a solution that works for everyone. There is well known and clear
ASF process for vetos and following that will help avoid these type of
exchanges. From whats been said so far about this issue it seems like
the rest binding invoker has no tests for this function and was only
working by relying on an existing bug so having that change while we
clean up trunk on the way to 2.0 is no cause for getting grumpy. There
has already been a fix for that suggested in TUSCANY-4029, if that
doesn't completely resolve the issue then respectful dev in trunk and
dev-list is the way to get to something that does.

   ...ant