[ https://issues.apache.org/jira/browse/TUSCANY-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ramkumar Ramalingam updated TUSCANY-2277:
-----------------------------------------
Attachment: TUSCANY-2277-Part1.patch
As the changes seems to be huge for this issue, i am providing with a incremental patch...
more patches are in the pipe-line. Here I have attached Part1 of the changes.
> Standardization of registering msg with monitor
> -----------------------------------------------
>
> Key: TUSCANY-2277
> URL: https://issues.apache.org/jira/browse/TUSCANY-2277
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Ramkumar Ramalingam
> Assignee: Ramkumar Ramalingam
> Fix For: Java-SCA-Next
>
> Attachments: TUSCANY-2277-Part1.patch
>
>
> Lokking at the monitors that are being hooked up with different parts of the code, found
that we have some inconsistency interms of raising warning & errors. In some places we
throw exceptions and in other places we raise a warning.
>
> Here are some examples for the inconsistency.......
>
> BaseConfigurationBuilderImpl.java
> Here we raise only a warning for URISyntaxException, should we not throw an exception
too?
>
> BaseWireBuilderImpl.java
> Here we throw exceptions for IncompatibleInterfaceContractException, don't you think
we also need to register this message in our monitor?
> In the same class, we raise a warning message for the PolicyRelated Exceptions, should
we also throw an exception here?
>
> CompositeProcessor.java
> There are instances where we throw new ContributionReadException, i believe registering
this msg with a monitor is also required as this is caused by incorrect user input.
> From Simon's comments on how we can go ahead with handling such instance, we will fix
the issue as discussed....
> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
|