Mailing-List: contact tuscany-dev-help@ws.apache.org; run by ezmlm
Precedence: bulk
Reply-To: tuscany-dev@ws.apache.org
Received-SPF: pass (athena.apache.org: domain of simonslaws@googlemail.com
 designates 209.85.146.180 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=Od9Ohcf5SFg1C16G8p5p5RbxUM3ePEr/nE9mhS1rcOmwd8sIaGQCVIhVfTEN+4AEKG/4i/IN4JVMswEfv2Hykf/4mCmBDmmMOdp/Eou98+n/78ISYW81/Uekv6TkfkqOpfvHO8h9as/Vjv1XhI71A+5fPu+tNyrEe5cQiEiyskE=
Message-ID: <c0c051b50802040730i552eb8fas4b4fb8aeda18c503@mail.gmail.com>
Date: Mon, 4 Feb 2008 15:30:33 +0000
From: "Simon Laws" <simonslaws@googlemail.com>
To: tuscany-dev@ws.apache.org
Subject: Re: [jira] Commented: (TUSCANY-1999) ConversationAttributes and
 expiry doesn't work with Stateless Conversational components
In-Reply-To: <30222713.1202127907747.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_7552_30962593.1202139033549"
References: <23379481.1200569073826.JavaMail.jira@brutus>
	 <30222713.1202127907747.JavaMail.jira@brutus>

------=_Part_7552_30962593.1202139033549
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Feb 4, 2008 12:25 PM, Thomas Greenwood (JIRA) <tuscany-dev@ws.apache.org>
wrote:

>
>    [
> https://issues.apache.org/jira/browse/TUSCANY-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565331#action_12565331]
>
> Thomas Greenwood commented on TUSCANY-1999:
> -------------------------------------------
>
> BTW I'd like the patch committed if possible since that's what we're
> currently working with.
>
> > ConversationAttributes and expiry doesn't work with Stateless
> Conversational components
> >
> ---------------------------------------------------------------------------------------
> >
> >                 Key: TUSCANY-1999
> >                 URL: https://issues.apache.org/jira/browse/TUSCANY-1999
> >             Project: Tuscany
> >          Issue Type: Bug
> >          Components: Java SCA Core Runtime
> >    Affects Versions: Java-SCA-1.1
> >            Reporter: Ben Smith
> >            Assignee: Simon Laws
> >             Fix For: Java-SCA-Next
> >
> >         Attachments: ConversationExpiry.patch
> >
> >
> > In services that are marked as @Conversational yet have scope of
> STATELESS the following problems occur
> > Caused by:
> org.apache.tuscany.sca.implementation.java.introspect.impl.InvalidConversationalImplementation:
> Service is marked with @ConversationAttributes but the scope is not
> @Scope("CONVERSATION")
> >       at
> org.apache.tuscany.sca.implementation.java.introspect.impl.ConversationProcessor.visitClass
> (ConversationProcessor.java:57)
> > Also looking at the code it looks as if that expiring of conversations
> only occurs with services that are of scope CONVERSATION. I believe that the
> above should work with all services marked as @Conversational.
> > To fix this I'm thinking that the job of expiring conversations should
> be moved from the ConversationalScopeContainer into the ConversationManager
> and the check in the ConversationProcessor changed to check for the
> @Conversational tag not @Scope("CONVERSATION")
> > Ben
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
> Hi Thomas

I took a preliminary look at the patch and from what I've seen it looks good
so far. Had hoped to commit this straight away but I've been unwell for the
last couple of days so didn't get it done. Back on the case now so I'll go
through it again and ask questions as required.

Regards

Simon

------=_Part_7552_30962593.1202139033549--