Return-Path: Delivered-To: apmail-ws-tuscany-dev-archive@locus.apache.org Received: (qmail 11143 invoked from network); 6 Apr 2007 14:31:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Apr 2007 14:31:46 -0000 Received: (qmail 94462 invoked by uid 500); 6 Apr 2007 14:31:53 -0000 Delivered-To: apmail-ws-tuscany-dev-archive@ws.apache.org Received: (qmail 94216 invoked by uid 500); 6 Apr 2007 14:31:51 -0000 Mailing-List: contact tuscany-dev-help@ws.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: tuscany-dev@ws.apache.org Delivered-To: mailing list tuscany-dev@ws.apache.org Received: (qmail 94207 invoked by uid 99); 6 Apr 2007 14:31:51 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Apr 2007 07:31:51 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: local policy) Received: from [216.148.227.153] (HELO rwcrmhc13.comcast.net) (216.148.227.153) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Apr 2007 07:31:43 -0700 Received: from [192.168.1.7] (c-71-202-137-73.hsd1.ca.comcast.net[71.202.137.73]) by comcast.net (rwcrmhc13) with ESMTP id <20070406143122m13005vl27e>; Fri, 6 Apr 2007 14:31:22 +0000 Message-ID: <461659AF.1030505@apache.org> Date: Fri, 06 Apr 2007 07:31:11 -0700 From: Jean-Sebastien Delfino User-Agent: Thunderbird 1.5.0.10 (X11/20070221) MIME-Version: 1.0 To: tuscany-dev@ws.apache.org Subject: Re: Closing Streams, was Re: svn commit: r525992 - in /incubator/tuscany/java/sca/modules/assembly-xml/src/main/java/org/apache/tuscany/assembly/xml/impl: ComponentTypeDocumentProcessor.java CompositeDocumentProcessor.java ConstrainingTypeDocumentProcess References: <5a75db780704052320k65f2239cja54ae38c7cc687f5@mail.gmail.com> In-Reply-To: <5a75db780704052320k65f2239cja54ae38c7cc687f5@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Luciano Resende wrote: > Hi Sebastien > > On the code below, should we close the stream after it is being > consumed ? > > XMLStreamReader reader = inputFactory.createXMLStreamReader( > url.openStream()); > > I didn't see it being closed inside the CompositeProcessor.read() or > CompositeDocumentProcessor.read() > > Yes :) Do you want to make the change? or should I do it? -- Jean-Sebastien --------------------------------------------------------------------- To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org For additional commands, e-mail: tuscany-dev-help@ws.apache.org