From tuscany-dev-return-16850-apmail-ws-tuscany-dev-archive=ws.apache.org@ws.apache.org Mon Apr 16 05:23:17 2007 Return-Path: Delivered-To: apmail-ws-tuscany-dev-archive@locus.apache.org Received: (qmail 48146 invoked from network); 16 Apr 2007 05:23:17 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 16 Apr 2007 05:23:17 -0000 Received: (qmail 60462 invoked by uid 500); 16 Apr 2007 05:23:22 -0000 Delivered-To: apmail-ws-tuscany-dev-archive@ws.apache.org Received: (qmail 60431 invoked by uid 500); 16 Apr 2007 05:23:22 -0000 Mailing-List: contact tuscany-dev-help@ws.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: tuscany-dev@ws.apache.org Delivered-To: mailing list tuscany-dev@ws.apache.org Received: (qmail 60418 invoked by uid 99); 16 Apr 2007 05:23:22 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Apr 2007 22:23:22 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of enjoyjava@gmail.com designates 64.233.162.229 as permitted sender) Received: from [64.233.162.229] (HELO nz-out-0506.google.com) (64.233.162.229) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Apr 2007 22:23:15 -0700 Received: by nz-out-0506.google.com with SMTP id m7so1137198nzf for ; Sun, 15 Apr 2007 22:22:54 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:from:to:references:subject:date:mime-version:content-type:content-transfer-encoding:x-priority:x-msmail-priority:x-mailer:x-mimeole; b=FD4tQ+r6X99onE/cxNBoro4ieEnBgU81jbwv0r6jne2QiNDynykVSxudtjoTe2Hpm0meOYY78yzpnLlzOx6ZFnNs1F8VnRFIlKVCa1VE5letboZq/c1KVsSpPa7rWnlLrpoaLlYn1c2wW5gtH6+VtF1PY/eE/7rkZRBPRF88+18= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:from:to:references:subject:date:mime-version:content-type:content-transfer-encoding:x-priority:x-msmail-priority:x-mailer:x-mimeole; b=o/JyJCtEJyHYw/mE3h/GpKV1Zc8M/aray5vHy75dOaPna9qroKPDD9NiOJlJ5KyAxlG714w1btnpNYEXf6OjuI//IyFNap6Fw98vr1u+upx2IVdqBEau9PdQ7qDIeiOsek2BbS780+qkGbkkt7Iss1d4odLrOu5KspCh+MSCRXE= Received: by 10.65.114.11 with SMTP id r11mr486435qbm.1176700974686; Sun, 15 Apr 2007 22:22:54 -0700 (PDT) Received: from rfengt60p ( [76.200.183.253]) by mx.google.com with ESMTP id 5sm23912639nzk.2007.04.15.22.22.53; Sun, 15 Apr 2007 22:22:54 -0700 (PDT) Message-ID: <003c01c77fe7$4db2e0d0$0300a8c0@rfengt60p> From: "Raymond Feng" To: References: Subject: Re: SDO Databinding test failure Date: Sun, 15 Apr 2007 22:23:00 -0700 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.3028 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3028 X-Virus-Checked: Checked by ClamAV on apache.org Hi, This is a good fix. I just committed it. Thanks, Raymond ----- Original Message ----- From: "Simon Laws" To: "tuscany-dev" Sent: Sunday, April 15, 2007 2:40 PM Subject: SDO Databinding test failure >I just made the following change in ImportSDOProcessorTestCase to make the > SDO tests work. See commented out/new line below. The loader in this case > dereferences the rolver so you can't pass in null without getting an NPE. > I'm not sure what the intention is here so I haven't checked this in. We > could either create the DefaultArtifactResolver here, test for null in the > loader and do nothing if null is passed in or preferably both. > > public void testFactory() throws Exception { > String xml = ""; > XMLStreamReader reader = getReader(xml); > assertFalse(inited); > ImportSDO importSDO = loader.read(reader); > assertNotNull(importSDO); > //loader.resolve(importSDO, null); > loader.resolve(importSDO, new DefaultArtifactResolver()); > assertTrue(inited); > } > > Simon > --------------------------------------------------------------------- To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org For additional commands, e-mail: tuscany-dev-help@ws.apache.org