From issues-return-166-archive-asf-public=cust-asf.ponee.io@training.apache.org Mon Aug 5 11:44:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7F701180181 for ; Mon, 5 Aug 2019 13:44:02 +0200 (CEST) Received: (qmail 60034 invoked by uid 500); 5 Aug 2019 11:44:02 -0000 Mailing-List: contact issues-help@training.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@training.apache.org Delivered-To: mailing list issues@training.apache.org Received: (qmail 60024 invoked by uid 99); 5 Aug 2019 11:44:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Aug 2019 11:44:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CB7A9E2F6F for ; Mon, 5 Aug 2019 11:44:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3E9C12665D for ; Mon, 5 Aug 2019 11:44:00 +0000 (UTC) Date: Mon, 5 Aug 2019 11:44:00 +0000 (UTC) From: "Stephan Harbauer (JIRA)" To: issues@training.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TRAINING-19) Github Beginner Level Training material MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TRAINING-19?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D169= 00024#comment-16900024 ]=20 Stephan Harbauer commented on TRAINING-19: ------------------------------------------ +{color:#1c1e29}General comments:{color}+ {color:#1c1e29}First of all, thanks for sharing and a great idea to open so= urce it :){color} {color:#1c1e29}After reading through the slide deck, I asked myself: is thi= s a slide deck for a workshop where someone is doing the training or should= this slide deck also work for self-teaching? As training, it's a pretty go= od deck. But I could imagine for the Apache Foundation; it's more helpful i= f it would be more self-explaining? If this is the case, maybe a webpage in= stead of a slide deck could be more {color}{color:#1c1e29}helpful{color}{co= lor:#1c1e29}?{color} =C2=A0 +Comments on the structure:+ {color:#1c1e29}As far as I understood the slide deck, it currently has the = following structure. I like the structure and would {color}{color:#1c1e29}j= ust{color}{color:#1c1e29} add three little things.{color} =C2=A0 {color:#1c1e29}(1) Committer explained{color} {color:#1c1e29}({color}*missing*{color:#1c1e29}) Contributor is not defined= (or is the committer in Apache wording the contributor?){color} {color:#1c1e29}(2) Readme (Project setup) explained{color} {color:#1c1e29}({color}*missing*{color:#1c1e29}) The motivation for a good = readme is missing: why you want other people to understand how to contribut= e so that they can help you{color} {color:#1c1e29}(3) Git/Github basics{color} {color:#1c1e29}(3.1) user and ssh keys or tokens (setup Git and Github){col= or} {color:#1c1e29}(3.2) Git Flows (GitHub Flow aka branch or fork){color} {color:#1c1e29}(3.3 Git branch model{color} {color:#1c1e29}(3.4) Git stages (stash, local repo, remote repo{color}{colo= r:#1c1e29}...{color}{color:#1c1e29}) incl. Push and Pull{color} {color:#1c1e29}(3.5) {color}{color:#1c1e29}Reflog{color} {color:#1c1e29}(4) Pull Requests + Reviews{color} {color:#1c1e29}(4.1) How to create a PR{color} {color:#1c1e29}(4.2) Make a good PR{color} {color:#1c1e29}(4.3) Review (How to?){color} {color:#1c1e29}({color}*missing*{color:#1c1e29}) When to open the PR? (at t= he beginning of the implementation to allow others to follow the progress o= r at the end when everything is perfect){color} {color:#1c1e29}(5) Merge or Rebase{color} {color:#1c1e29}(5.1) Explain both{color} {color:#1c1e29}(5.2) Show potential issues when used "wrong."{color} {color:#1c1e29}(6) Tips and tricks{color} {color:#1c1e29}(7) Tooling{color} {color:#1c1e29}(7.1) Review Tooling{color} {color:#1c1e29}(7.2) History tooling{color} {color:#1c1e29}(7.3) Project configuration{color} {color:#1c1e29}(7.4) Templates for project configuration{color} {color:#1c1e29}(7.5) Failure prevention with automation{color} =C2=A0 =C2=A0 +{color:#1c1e29}Detail comments on specific slides:{color}+ {color:#1c1e29}- Slide 8: what does this mean? Committer, Project managemen= t committee{color}{color:#1c1e29}...{color}{color:#1c1e29} here I need an e= xplanation of what this slide should communicate.{color} {color:#1c1e29}Slide 9: What are the accountabilities of a committer -> may= be add: Companies that build SAAS products and have the practice of 'you bu= ild it, you run it' also means that the (trusted) committers need to take o= ver the responsibility of operating the contribution.{color} {color:#1c1e29}Slide 20-22: Maybe an explanation slide to show we have two = different approaches on how to contribute via Git(Hub). Otherwise, newbies = could get lost.{color} {color:#1c1e29}Slide 23f.: Collaborating: More than one remote -> Within a = training, the slides are excellent. Just scroll the slides without the trai= ner explaining everything it's not understandable if you are new to forks. = Explanations on the slides or within the speaker note section should help{c= olor} {color:#1c1e29}Slide 32f.: Making changes -> I don't understand (based on t= he pictures and speaker notes) how branches, merges and rebases are working= . There is also plenty of space on the slides. More explanations {color}{co= lor:#1c1e29}on{color}{color:#1c1e29} the slides could help.{color} {color:#1c1e29}Slides 44f.: Same as before - even worse{color} {color:#1c1e29}Slide 56: Excercise 1 -> another slide with the learnings sh= ould help to validate their own experiences during the exercise.{color} {color:#1c1e29}Slide 62: "Pull these pull requests together in one issue." = -> What do you mean by that? Github Issues from the project management feat= ure?{color} {color:#1c1e29}Slide 63: Could also explain that different level of pull re= quest comments are available and should be used ({color}{color:#1c1e29}like= :{color}{color:#1c1e29} mandatory change, and nice to have {color}{color:#1= c1e29}change{color}{color:#1c1e29}){color} {color:#1c1e29}Slide 71: Excercise 3 -> add {color}{color:#1c1e29}an additi= onal{color}{color:#1c1e29} slide to explain what (should have) happened dur= ing the exercise.{color} =C2=A0 =C2=A0 {color:#1c1e29}Once again: it's an awesome initiative to open source this. = Let me know how you like to continue. I'm happy to support.{color} > Github Beginner Level Training material > --------------------------------------- > > Key: TRAINING-19 > URL: https://issues.apache.org/jira/browse/TRAINING-19 > Project: Apache Training > Issue Type: New Feature > Reporter: Isabel Drost-Fromm > Priority: Major > > A couple weeks ago we ran a Github training at Europace. As most of what = we explained there is based on the concept of Inner Source which itself is = fairly close to the Apache Way I thought it might make sense to submit an a= dapted version here. > Caveat: Slides currently live in Google Slides. So we'd need to figure ou= t how best to convert them into a format the works for you. > Caveat 2: Most of the Slides contain only graphics. > =C2=A0 > I'll need to go over them and translate from German to English anyway, ho= wever I'd rather do that only once ;) -- This message was sent by Atlassian JIRA (v7.6.14#76016)