trafodion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmar...@apache.org
Subject [2/3] incubator-trafodion git commit: Update statistics auth check update from code review
Date Wed, 07 Jun 2017 00:10:17 GMT
Update statistics auth check update from code review


Project: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/commit/d87f71d2
Tree: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/tree/d87f71d2
Diff: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/diff/d87f71d2

Branch: refs/heads/master
Commit: d87f71d2db0e59883a218489af3129b28eac0e02
Parents: 63b275d
Author: Roberta Marton <rmarton@edev07.esgyn.local>
Authored: Tue Jun 6 16:02:25 2017 +0000
Committer: Roberta Marton <rmarton@edev07.esgyn.local>
Committed: Tue Jun 6 16:02:25 2017 +0000

----------------------------------------------------------------------
 core/sql/ustat/hs_globals.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-trafodion/blob/d87f71d2/core/sql/ustat/hs_globals.cpp
----------------------------------------------------------------------
diff --git a/core/sql/ustat/hs_globals.cpp b/core/sql/ustat/hs_globals.cpp
index 827304c..d78f5fc 100644
--- a/core/sql/ustat/hs_globals.cpp
+++ b/core/sql/ustat/hs_globals.cpp
@@ -3776,11 +3776,11 @@ NABoolean HSGlobalsClass::isAuthorized(NABoolean isShowStats)
        if (privs == NULL)
          {
            *CmpCommon::diags() << DgSqlCode(-1034);
-            return FALSE;
+            authorized = FALSE;
          }
 
        // Requester must have at least select privilege
-       if ( privs->hasSelectPriv() )
+       else if ( privs->hasSelectPriv() )
          authorized = TRUE;
        else
          {
@@ -3788,7 +3788,7 @@ NABoolean HSGlobalsClass::isAuthorized(NABoolean isShowStats)
             << DgSqlCode( -4481 )
             << DgString0( "SELECT or MANAGE_STATISTICS" )
             << DgString1( objDef->getNATable()->getTableName().getQualifiedNameAsAnsiString()
);
-            return FALSE;
+            authorized = FALSE;
           }
        }
 


Mime
View raw message