trafficserver-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan M. Carroll (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (TS-1021) traffic_logstats fails on zwoop's machine
Date Mon, 14 Nov 2011 23:03:52 GMT
traffic_logstats fails on zwoop's machine
-----------------------------------------

                 Key: TS-1021
                 URL: https://issues.apache.org/jira/browse/TS-1021
             Project: Traffic Server
          Issue Type: Bug
          Components: Logging
    Affects Versions: 3.1.0
            Reporter: Alan M. Carroll
            Assignee: Alan M. Carroll
             Fix For: 3.1.1


As best I can track this down, the problem arises during log creation. For reasons I would
prefer to not know, log buffers are written to binary files using the LogFile.cc:writeln which
helpful appends a newline to the binary day. Unless the binary data already ends with a newline,
in which case it doesn't. logstats, when reading the file, always add an extra byte to read
to skip over this newline, which can be problematic in the latter case. Whether this happens
seems to depend on the client brower because the last field in the standard log format is
XID, a MIME field. LogAccessHttp::marshal_client_accelerator_id pulls the XID out of the MIME
fields and then adds one to the returned length, to account for the possibly non-existent
terminating nul (it being a MIME field). That extra byte gets carried along and written out
as part of the XID. If it turns out to be a newline, then there is a problem.

There's so much wrongness here I don't even know where to start. There's even expensive code
in both logcat to detect small shifts (such as being off by one due to a missing newline)
and re-synchronize. logstats has similar code but it only used when starting at an offset
in to the log file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message