trafficserver-github mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [trafficserver] shinrich commented on pull request #6889: Improve client_vc tracking
Date Tue, 30 Jun 2020 13:11:01 GMT

shinrich commented on pull request #6889:
URL: https://github.com/apache/trafficserver/pull/6889#issuecomment-651780537


   Hmm, the do_io_write(this, 0, nullptr) in Http1ClientSession::do_io_close() appears to
be meaningless upon closer inspection.
   
   After that do_io_write, we either call _vc->do_io_close() if the connection is not half_closed
which clears both the read and write vios, or we call do_io_shutodown(WRITE) which contrary
to the comment appears to clear the write vio.   I'll go ahead and set up a build with that
line removed to verify that it does not cause immediate harm if removed. 
   
   For the issue #6924, the addition of logic to HttpSM::tunnel_handler_post_ua to directly
close the client connection on error cleared up that crash in our environment.   The code
was added to this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message