From dev-return-14124-archive-asf-public=cust-asf.ponee.io@trafficserver.apache.org Tue Jul 10 21:19:21 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A17E7180634 for ; Tue, 10 Jul 2018 21:19:20 +0200 (CEST) Received: (qmail 1085 invoked by uid 500); 10 Jul 2018 19:19:19 -0000 Mailing-List: contact dev-help@trafficserver.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@trafficserver.apache.org Delivered-To: mailing list dev@trafficserver.apache.org Received: (qmail 1072 invoked by uid 99); 10 Jul 2018 19:19:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Jul 2018 19:19:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 874F4C0026 for ; Tue, 10 Jul 2018 19:19:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.131 X-Spam-Level: X-Spam-Status: No, score=-0.131 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=oath.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 4wP2aHufMo2h for ; Tue, 10 Jul 2018 19:19:17 +0000 (UTC) Received: from mail-yb0-f174.google.com (mail-yb0-f174.google.com [209.85.213.174]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 0F2DC5F238 for ; Tue, 10 Jul 2018 19:19:17 +0000 (UTC) Received: by mail-yb0-f174.google.com with SMTP id s1-v6so9067460ybk.3 for ; Tue, 10 Jul 2018 12:19:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=WW0S2lAqi//3fEpMczQ/CAKkDPscOX7cez0NjT3x33w=; b=CVJ7cAhUzN69L08FsLBuDlJwZVCC9YTboSIQHE3JxcJotk8l4Lm3CC8zCwgXIw2xBR TeecWyI6TZbJHNXwaR0KjIZQxSo8WSDjthehNGSdbDyEeLIXGx8MV/rN4UL+DifdTjsA dKosYlsej8gEto5iyXryoJ6yzyf/p7z4liMdKUXwT6pBLah4gsE1LUfGlKbcJI11HM9Z c4hPrCVe1AUxTjiCFpjZASXIZP4KXi2EbsH5pgOQF4ItsLIICwC2p2ee9OS8fCM3KDvZ MDhQ3o7j1u0Ztj5ba0c/bhgHzzAo4+USoyanySlVhQG/K1GoavceGeZMDd9bHoC3L671 NFwQ== X-Gm-Message-State: APt69E3s/mnkyafsfErmJOwBA9D0x/06aYJZkP9NKEx3vJ9KSO0v9MN2 cGfOpyTJMce6qTTbYhB/VbMIWm9b3IQHJ34NpONM8Q== X-Google-Smtp-Source: AAOMgpcB4vLySmIDqL3kjZ3SPfClWfhv+asdnX6sZQsAQArbCACboj9oQiWaZJ0yzgXhy6nRiiEa9r4LoAmGE4u18kQ= X-Received: by 2002:a25:5e02:: with SMTP id s2-v6mr7777411ybb.17.1531250356344; Tue, 10 Jul 2018 12:19:16 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:bc88:0:0:0:0:0 with HTTP; Tue, 10 Jul 2018 12:19:15 -0700 (PDT) From: Walt Karas Date: Tue, 10 Jul 2018 14:19:15 -0500 Message-ID: Subject: xdebug plugin To: dev@trafficserver.apache.org Content-Type: text/plain; charset="UTF-8" For the xdebug plugin, does anybody object if I move the removal of the x-debug header field from the READ_RESPONSE_HDR_HOOK to the CACHE_LOOKUP_COMPLETE_HOOK? There's an Oath internal plugin that runs on the POST_REMAP_HOOK that needs to see whether x-debug is present or not. If the x-debug header is not removed prior to cache lookup, can it affect the cache key (he asked, thinking it would be crazy if the answer is yes but fearing it may be yes anyway)?