trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jpeach <>
Subject [GitHub] trafficserver pull request #788: TS-4635: Fix RefCountCacheSerializer file d...
Date Wed, 06 Jul 2016 16:24:41 GMT
GitHub user jpeach opened a pull request:

    TS-4635: Fix RefCountCacheSerializer file descriptor leaks.

    Fix various file descriptor leaks on the RefCountCacheSerializer error path. Move RefCountCacheSerializer
to a separate header so that it only gets included in the one place that needs it.

You can merge this pull request into a Git repository by running:

    $ git pull fix/4635

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #788
commit bf84d640e0fa5fb3720daade20e49109f6df4e80
Author: James Peach <>
Date:   2016-07-06T16:01:32Z

    TS-4635: Fix RefCountCacheSerializer file descriptor error path.
    Simplify RefCountCacheSerializer::finalize_sync() and consistently
    propagate the error to the caller as -errno so we can log any errors
    in the caller. Retail the open file descriptor on error.
    Close the open file descriptor and deliver the completion event in
    the serializer destructor. This handles the error case.

commit 2c4b35287f070cb8c06cb470a0d6d0a0c5dd556c
Author: James Peach <>
Date:   2016-07-06T16:20:35Z

    TS-4635: Move RefCountCacheSerializer to a separate header.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message