trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From strotyl <...@git.apache.org>
Subject [GitHub] trafficserver pull request #783: TS-3816 : Replace ptr_len_cmp with memcmp
Date Wed, 06 Jul 2016 18:53:02 GMT
Github user strotyl commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/783#discussion_r69789926
  
    --- Diff: proxy/StatPages.cc ---
    @@ -83,7 +83,7 @@ StatPagesManager::handle_http(Continuation *cont, HTTPHdr *header)
         host_len       = unescapifyStr(host);
     
         for (i = 0; i < n_stat_pages; i++) {
    -      if (ptr_len_cmp(host, host_len, stat_pages[i].module) == 0) {
    +      if ((host_len == sizeof(stat_pages[i].module)) && (memcmp(host, stat_pages[i].module,
host_len) == 0)) { 
    --- End diff --
    
    Looks like that should work and we won't need the len checks. According to the doc...
    
    This function starts comparing the first character of each string. If they are equal to
each other, it continues with the following pairs until the characters differ, until a terminating
null-character is reached, or until num characters match in both strings, whichever happens
first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message