trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jpeach <...@git.apache.org>
Subject [GitHub] trafficserver pull request #786: TS-4396: fix number_of_redirections off-by-...
Date Wed, 06 Jul 2016 18:13:45 GMT
Github user jpeach commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/786#discussion_r69782549
  
    --- Diff: proxy/http/HttpSM.cc ---
    @@ -1954,9 +1954,7 @@ HttpSM::state_read_server_response_header(int event, void *data)
         t_state.api_next_action       = HttpTransact::SM_ACTION_API_READ_RESPONSE_HDR;
     
         // if exceeded limit deallocate postdata buffers and disable redirection
    -    if (enable_redirection && (redirection_tries < t_state.txn_conf->number_of_redirections))
{
    -      ++redirection_tries;
    -    } else {
    +    if (enable_redirection && (redirection_tries >= t_state.txn_conf->number_of_redirections))
{
    --- End diff --
    
    Yes, I asked about this because I was not sure whether we should be checking the response
here. The problem that I see with this change is that the condition disagrees with ``is_redirect_required()``
when ``redirection_tries`` is equal to ``number_of_redirections``.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message