trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zwoop <...@git.apache.org>
Subject [GitHub] trafficserver pull request #763: TS-4610: Fix HTTP and HTTP2 stats
Date Wed, 06 Jul 2016 01:55:36 GMT
Github user zwoop commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/763#discussion_r69666098
  
    --- Diff: proxy/http/HttpSM.cc ---
    @@ -200,7 +200,8 @@ HttpVCTable::cleanup_entry(HttpVCTableEntry *e)
         // Update stats
         switch (e->vc_type) {
         case HTTP_UA_VC:
    -      //              HTTP_DECREMENT_DYN_STAT(http_current_client_transactions_stat);
    +      // Moved to HttpSM::destroy
    +      // HTTP_DECREMENT_DYN_STAT(http_current_client_transactions_stat);
    --- End diff --
    
    I don't know if we need to keep these commented out, but maybe  just a comment saying
"Metrics are updated in ::destroy".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message