trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Kenny <jke...@yahoo-inc.com.INVALID>
Subject Re: clang format
Date Thu, 28 Jan 2016 17:41:53 GMT
Yep that did the trick

Jason


----- Original Message -----
From: Jason Kenny <jkenny@yahoo-inc.com.INVALID>
To: "dev@trafficserver.apache.org" <dev@trafficserver.apache.org>; Alan Carroll <solidwallofcode@yahoo-inc.com>
Sent: Thursday, January 28, 2016 11:34 AM
Subject: Re: clang format

Ahh.. I did not use the magic version. Let me try to get this on my system correctly.

Thanks
Jason




----- Original Message -----
From: Alan Carroll <solidwallofcode@yahoo-inc.com.INVALID>
To: "dev@trafficserver.apache.org" <dev@trafficserver.apache.org>
Sent: Thursday, January 28, 2016 11:32 AM
Subject: Re: clang format

Did you use Leif's magic clang[1]? Unfortunately clang apparently changes its formatting frequently
and without recourse so you must use that precise version to be consistent. In general you
should not see that many files changed.


[1] https://bintray.com/apache/trafficserver/clang-format-tools/view





On Thursday, January 28, 2016 11:24 AM, Jason Kenny <jkenny@yahoo-inc.com.INVALID> wrote:


Hi,

I was updating a patch by running clang-format. However when I ran this I noticed that I have
a lot of files that are now different (50+ files). Should this be happening. I ran this on
fedora 23. I would have thought I should only see changes in the one file I modified, ie taffic_via.cc.

Thanks for any advice.

Jason

Mime
View raw message