trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jpeach <...@git.apache.org>
Subject [GitHub] trafficserver pull request: Add TSSslContextCreate method
Date Tue, 05 Jan 2016 05:00:39 GMT
Github user jpeach commented on the pull request:

    https://github.com/apache/trafficserver/pull/402#issuecomment-168898043
  
    This looks pretty reasonable to me. @shinrich, what do you think?
    
    In ``ts/ts.h``, ``TSSslContextCreate()`` needs to be ``TSSslContextCreate(void)``.
    
    Once a plugin calls ``TSSslContextCreate()``, does it make sense for it to have to call
``SSL_CTX_free()``? I'm probably OK with that as long as we document.
    
    Does it make sense to also hoist the session ticket initialization up into ``SSLInitServerContext()``?
    
    Since this is a change to the public API we need to do an [API review](https://cwiki.apache.org/confluence/display/TS/API+Review+Process)
on the dev@ list. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message