Mailing-List: contact dev-help@trafficserver.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@trafficserver.apache.org
From: oknet <git@git.apache.org>
To: dev@trafficserver.apache.org
Reply-To: dev@trafficserver.apache.org
References: <git-pr-366-trafficserver@git.apache.org>
In-Reply-To: <git-pr-366-trafficserver@git.apache.org>
Subject: [GitHub] trafficserver pull request: remove alloc_cache from
 NetAccept
Content-Type: text/plain
Message-Id: <20151208151517.86FC7DFD7B@git1-us-west.apache.org>
Date: Tue,  8 Dec 2015 15:15:17 +0000 (UTC)

Github user oknet commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/366#discussion_r46964787
  
    --- Diff: iocore/net/UnixNetAccept.cc ---
    @@ -112,9 +106,17 @@ net_accept(NetAccept *na, void *ep, bool blockable)
           count = res;
           goto Ldone;
         }
    +    
    +    vc = (UnixNetVConnection *)na->getNetProcessor()->allocate_vc(e->ethread);
    +    if (!vc) {
    +      con.close();
    +      goto Ldone;
    +    }
    +    
         count++;
    -    na->alloc_cache = NULL;
    -
    +    NET_SUM_GLOBAL_DYN_STAT(net_connections_currently_open_stat, 1);
    +    vc->id = net_next_connection_number();
    +    vc->con = con;
    --- End diff --
    
    Connection::move() not existed, I'm set the con.fd to NO_FD to avoid con.fd closed by ~Connection()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---