trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danobi <...@git.apache.org>
Subject [GitHub] trafficserver pull request: TS-4057 Missing check for system call ...
Date Mon, 07 Dec 2015 17:05:46 GMT
GitHub user danobi opened a pull request:

    https://github.com/apache/trafficserver/pull/367

    TS-4057 Missing check for system call error

    EPERM and EACCES are often consfused for each other.
    
    EPERM means "operation not permitted", ie doing this would not be
    in your best interest.
    EACCES means "permission denied", meaning if you run this command
    as sudo it will work.
    
    Opening a log file will _probably_ never be bad, and even if the
    system says so, it shouldn't be bad. So in this case it doesn't
    hurt to leave both conditions in here.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/danobi/trafficserver TS-4057

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/367.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #367
    
----
commit 1a996d5a750b854c2d492ac2f6d20d9e5049cb5b
Author: Daniel Xu <dlxu2@yahoo.com>
Date:   2015-12-07T17:03:14Z

    TS-4057 Missing check for system call error
    
    EPERM and EACCES are often consfused for each other.
    
    EPERM means "operation not permitted", ie doing this would not be
    in your best interest.
    EACCES means "permission denied", meaning if you run this command
    as sudo it will work.
    
    Opening a log file will _probably_ never be bad, and even if the
    system says so, it shouldn't be bad. So in this case it doesn't
    hurt to leave both conditions in here.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message