trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danobi <...@git.apache.org>
Subject [GitHub] trafficserver pull request: TS-4054 Incorrect ink_assert behavior ...
Date Fri, 04 Dec 2015 17:33:12 GMT
GitHub user danobi opened a pull request:

    https://github.com/apache/trafficserver/pull/363

    TS-4054 Incorrect ink_assert behavior in Diags.cc

    `ink_assert(diags_log == NULL)` is incorrect since there are times
    when `blf` correctly has the value NULL. In that case, we would
    like for the function to do nothing and return early versus crash
    ATS via an assert. That is to say, semantically an early return is
    more clear than an assert.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/danobi/trafficserver TS-4054

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/363.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #363
    
----
commit 0191a4f367d868409b9b4f2935ecfdaa02414615
Author: Daniel Xu <dlxu2@yahoo.com>
Date:   2015-12-04T17:28:47Z

    TS-4054 Incorrect ink_assert behavior in Diags.cc
    
    `ink_assert(diags_log == NULL)` is incorrect since there are times
    when `blf` correctly has the value NULL. In that case, we would
    like for the function to do nothing and return early versus crash
    ATS via an assert. That is to say, semantically an early return is
    more clear than an assert.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message