trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From oknet <...@git.apache.org>
Subject [GitHub] trafficserver pull request: TS-4075: add a state check for sslHand...
Date Thu, 24 Dec 2015 13:01:02 GMT
Github user oknet commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/374#discussion_r48413673
  
    --- Diff: iocore/net/SSLNetVConnection.cc ---
    @@ -1400,10 +1416,9 @@ SSLNetVConnection::select_next_protocol(SSL *ssl, const unsigned
char **out, uns
     void
     SSLNetVConnection::reenable(NetHandler *nh)
     {
    -  if (this->sslPreAcceptHookState != SSL_HOOKS_DONE) {
    -    this->sslPreAcceptHookState = SSL_HOOKS_INVOKE;
    -    this->readReschedule(nh);
    -  } else {
    +  if (sslPreAcceptHookState != SSL_HOOKS_DONE) {
    +    sslPreAcceptHookState = SSL_HOOKS_INVOKE;
    +  } else if (sslHandshakeHookState == HANDSHAKE_HOOKS_INVOKE) {
         // Reenabling from the handshake callback
    --- End diff --
    
    I put the "this->readReschedule(nh)" at the end of reenable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message