trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shinrich <...@git.apache.org>
Subject [GitHub] trafficserver pull request: TS-4055: InactivityCop callback SM wit...
Date Wed, 23 Dec 2015 16:06:25 GMT
Github user shinrich commented on the pull request:

    https://github.com/apache/trafficserver/pull/373#issuecomment-166932419
  
    The change is small enough to be reasonable defensive code.  And it if got rid of your
crash, that is great. 
    
    However, a better solution may be to assign the server_entry->write_vio in HttpSM::attach_server_session
around line 5692
    
    {code}
    // Transfer control of the write side as well
      server_session->do_io_write(this, 0, NULL);
    {code}
    
    The call to do_io_read above assigned the results to server_entry->read_vio.  We should
do the same thing for the server_entry->write_vio.  Since the server_entry is set in this
function, if we set server_entry->write_vio here too, there would be no path with an unset
write_vio.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message